-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DeletionPolicy support for webhook provider (external-secrets#1… #2066
feat: DeletionPolicy support for webhook provider (external-secrets#1… #2066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.
Useful commands:
make fmt
: Formats the codemake check-diff
: Ensures the branch is cleanmake reviewable
: Ensures a PR is ready for review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could you please add a note to the provider docs that a 404 may cause secret deletion? 🙏
Signed-off-by: ArtificialQualia <kendall.masse@gmail.com>
…com/libertymutual/external-secrets into 1958-webhook-deletionpolicy-support
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This has now been added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this 🙇
Problem Statement
As identified in #1958 the webhook provider needs to be updated to return the correct error so that it may properly support the Merge/Delete DeletionPolicy.
Related Issue
Fixes #1958
Proposed Changes
This PR updates the webhook provider to return the appropriate error type on receiving a 404 from a webhook so that the DeletionPolicy logic will trigger correctly.
Checklist
git commit --signoff
make test
make reviewable