-
-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add values for extraContainers in deployment #2073
Add values for extraContainers in deployment #2073
Conversation
Signed-off-by: Benjamin Voigt <55484313+YurNaybor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.
Useful commands:
make fmt
: Formats the codemake check-diff
: Ensures the branch is cleanmake reviewable
: Ensures a PR is ready for review
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I'm currently struggling to get
|
Alright, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks for adding this, appreciated!
Signed-off-by: Benjamin Voigt <55484313+YurNaybor@users.noreply.github.com>
Signed-off-by: Benjamin Voigt <55484313+YurNaybor@users.noreply.github.com> Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>
Problem Statement
Adding sidecar containers to the external secrets operator.
Related Issue
Fixes #2072
Proposed Changes
Implementing the value
extraContainers
allows for simply configuring additional / sidecar containers via values.yamlChecklist
git commit --signoff
make test
make reviewable