Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add values for extraContainers in deployment #2073

Conversation

YurNaybor
Copy link
Contributor

@YurNaybor YurNaybor commented Mar 1, 2023

Problem Statement

Adding sidecar containers to the external secrets operator.

Related Issue

Fixes #2072

Proposed Changes

Implementing the value extraContainers allows for simply configuring additional / sidecar containers via values.yaml

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Signed-off-by: Benjamin Voigt <55484313+YurNaybor@users.noreply.github.com>
@YurNaybor YurNaybor requested a review from a team as a code owner March 1, 2023 11:28
@YurNaybor YurNaybor requested review from gusfcarvalho and removed request for a team March 1, 2023 11:28
Copy link
Contributor

@paul-the-alien paul-the-alien bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.

Useful commands:

  • make fmt: Formats the code
  • make check-diff: Ensures the branch is clean
  • make reviewable: Ensures a PR is ready for review

@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@YurNaybor
Copy link
Contributor Author

I'm currently struggling to get make reviewable run. Even after running make fmt it complains about files I didn't even touch:

pkg/provider/register/register.go:21:2: blank-imports: a blank import should be only in a main or test package, or have a comment justifying it (revive)
	_ "github.com/external-secrets/external-secrets/pkg/provider/akeyless"
	^
pkg/generator/register/register.go:21:2: blank-imports: a blank import should be only in a main or test package, or have a comment justifying it (revive)
	_ "github.com/external-secrets/external-secrets/pkg/generator/acr"
	^
pkg/provider/register/register.go:18:1: directive `//nolint:revive` is unused for linter "revive" (nolintlint)
//nolint:revive
^
pkg/generator/register/register.go:18:1: directive `//nolint:revive` is unused for linter "revive" (nolintlint)
//nolint:revive

@YurNaybor
Copy link
Contributor Author

Alright, make reviewable is working now that I reverted the (local) changes of make fmt.

Copy link
Member

@moolen moolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for adding this, appreciated!

@moolen moolen merged commit 2a1b95c into external-secrets:main Mar 6, 2023
sebagomez pushed a commit that referenced this pull request Mar 8, 2023
Signed-off-by: Benjamin Voigt <55484313+YurNaybor@users.noreply.github.com>
limistah pushed a commit to Onboardbase/external-secrets that referenced this pull request Mar 14, 2023
Signed-off-by: Benjamin Voigt <55484313+YurNaybor@users.noreply.github.com>
Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow extraContainers to be configured in Helm Chart
2 participants