Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement templateFrom #222

Merged
merged 1 commit into from
Jun 29, 2021
Merged

implement templateFrom #222

merged 1 commit into from
Jun 29, 2021

Conversation

moolen
Copy link
Member

@moolen moolen commented Jun 27, 2021 •
edited

This PR implements the templateFrom field. Also:

  • update go version to 1.16
  • update controller-runtime and k8s deps
  • update kubebuilder tools to run controller tests against 1.20 instead of 1.16.

Closes #179

@paul-the-alien paul-the-alien bot closed this Jun 27, 2021
paul-the-alien[bot]
paul-the-alien bot reviewed Jun 27, 2021
View reviewed changes
Copy link
Contributor

@paul-the-alien paul-the-alien bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be no description in your Pull Request.Please add an understanding of what this change proposes to do and why it is needed

@moolen moolen reopened this Jun 27, 2021
@moolen
Copy link
Member Author

moolen commented Jun 27, 2021

/ok-to-test sha=6e498ad

@moolen moolen marked this pull request as ready for review June 27, 2021 15:59
@moolen moolen requested a review from knelasevero June 28, 2021 19:46
@knelasevero
Copy link
Member

LGTM! 😄

@knelasevero
Copy link
Member

/approve

@moolen
Copy link
Member Author

moolen commented Jun 29, 2021

/merge

@paul-the-alien paul-the-alien bot merged commit 04219de into main Jun 29, 2021
@paul-the-alien paul-the-alien bot deleted the feat/template-from branch June 29, 2021 13:43
@atsai1220 atsai1220 mentioned this pull request Jul 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-the-alien paul-the-alien[bot] paul-the-alien approved these changes

@knelasevero knelasevero Awaiting requested review from knelasevero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExternalSecret TemplateFrom ConfigMap does not exist in CRD
2 participants
@moolen @knelasevero