Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): AWSSM quick example changes #225

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

knelasevero
Copy link
Member

@knelasevero knelasevero commented Jun 28, 2021

Changed some stuff on the AWS SM example to enable people that want to get this quickly up to test and not think that much about the specification.

  • Made it clear that role is a optional field, if they want to omit it for test purposes.
  • Made the ExternalSecret example there be the complete file since people would want to just copy and paste and apply it right away 馃槃

The reasoning is that awssm is the most popular provider and this will probably be the doc page with most accesses with people trying out the project.

@knelasevero knelasevero force-pushed the docs/aws_example_quick branch 2 times, most recently from 15f4f9e to f90df95 Compare June 28, 2021 15:15
@knelasevero
Copy link
Member Author

A bit of data 馃槃

image

@knelasevero
Copy link
Member Author

Also, we added you @moolen to the analytics dashboard.

@moolen
Copy link
Member

moolen commented Jun 28, 2021

/approve

@knelasevero
Copy link
Member Author

/merge

@paul-the-alien paul-the-alien bot merged commit 64e327e into main Jun 28, 2021
@paul-the-alien paul-the-alien bot deleted the docs/aws_example_quick branch June 28, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants