Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add templating to PushSecret #2926

Merged
merged 7 commits into from
Dec 22, 2023
Merged

feat: add templating to PushSecret #2926

merged 7 commits into from
Dec 22, 2023

Commits on Dec 22, 2023

  1. feat: add templating to PushSecret 

    Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
    @Skarlso
    Skarlso committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    c0aa8d5 View commit details
    Browse the repository at this point in the history

  2. adding unit tests around templating basic concepts and verifying output 

    Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
    @Skarlso
    Skarlso committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    343d1aa View commit details
    Browse the repository at this point in the history

  3. extracting some of the common functions of the parser 

    Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
    @Skarlso
    Skarlso committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    2141d71 View commit details
    Browse the repository at this point in the history

  4. remove some more duplication 

    Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
    @Skarlso
    Skarlso committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    49ab07a View commit details
    Browse the repository at this point in the history

  5. removed commented out code segment 

    Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
    @Skarlso
    Skarlso committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    52f7408 View commit details
    Browse the repository at this point in the history

  6. added documentation for templating feature 

    Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
    @Skarlso
    Skarlso committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    f16c977 View commit details
    Browse the repository at this point in the history

  7. simplified the templating for annotations and labels 

    Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
    @Skarlso
    Skarlso committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    965c9da View commit details
    Browse the repository at this point in the history