Allow Pulimi to extract structured data. #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow Pulimi to extract structured data. Close: external-secrets#3307 Signed-off-by: alphayax <alphayax@gmail.com>
Skarlso
reviewed
Mar 27, 2024
Signed-off-by: alphayax <alphayax@gmail.com>
|
Skarlso
approved these changes
Mar 27, 2024
|
Ah shit, I forgot to run the tests 🤦 |
|
I wonder if it works. |
|
/ok-to-test sha=28f0cda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle
json.RawMessageas a[]byteinutil.GetByteValue.This allow Pulimi to extract structured data.
Close: #3307
Problem Statement
Pulumi can't extract structured data
Related Issue
Fixes #3307
Proposed Changes
Pulumi use
json.RawMessagewho is a[]byte, but is not considered as is in the GetByteValue method. The proposed change is tested and fix the problem.Checklist
git commit --signoffmake testmake reviewable