Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix appRole example #333

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

kisel
Copy link
Contributor

@kisel kisel commented Aug 20, 2021

minor change for docs page https://external-secrets.io/provider-hashicorp-vault/ to avoid confusing example - secret accepts AppRole SecretId, not a 'vault-token'

VaultAppRole

Copy link
Contributor

@paul-the-alien paul-the-alien bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.

@knelasevero
Copy link
Member

Thanks @kisel !

@knelasevero
Copy link
Member

/approve

@knelasevero
Copy link
Member

/merge

@paul-the-alien paul-the-alien bot merged commit 8f06fda into external-secrets:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants