feat: add support to set Type for AWS parameter store #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Santos <vsantos.py@gmail.com>
|
Skarlso
previously approved these changes
Jun 12, 2024
|
Nicely done! |
|
/ok-to-test sha=28ab26f |
Skarlso
approved these changes
Jun 12, 2024
Bude8
pushed a commit
to Bude8/external-secrets
that referenced
this pull request
Jun 13, 2024
…ts#3576) Signed-off-by: Victor Santos <vsantos.py@gmail.com> Signed-off-by: Bude8 <henryblee8@gmail.com>
Bude8
pushed a commit
to Bude8/external-secrets
that referenced
this pull request
Jun 16, 2024
…ts#3576) Signed-off-by: Victor Santos <vsantos.py@gmail.com> Signed-off-by: Bude8 <henryblee8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Currently, we don't have the option to set which parameter type to use for the AWS parameter store, and as a result, all secrets are stored remotely as plain text
String. This PR adds the possibility to work with the following typesString,SecureString, andStringListthroughPushSecret's metadata.Related Issue
Fixes #3422
Checklist
git commit --signoffmake testmake reviewable