Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parameterstore): add support to set parameter tier for pushsecrets #3581

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

vsantos
Copy link
Contributor

@vsantos vsantos commented Jun 14, 2024

Problem Statement

Currently, we don't have the option to set which parameter tier to use for the AWS parameter store, and as a result, all secrets are stored using the default tier Standard. This PR adds the possibility to work with parameter tier Advanced and all its policies.

Related Issue

Fixes #3422

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Signed-off-by: Victor Santos <vsantos.py@gmail.com>
@vsantos vsantos requested a review from a team as a code owner June 14, 2024 02:03
@vsantos vsantos requested a review from Skarlso June 14, 2024 02:03
@vsantos
Copy link
Contributor Author

vsantos commented Jun 14, 2024

/ok-to-test sha=654c946e

@vsantos vsantos changed the title feat(parameterstore): add support to set parameter tier for pushsecrets draft: feat(parameterstore): add support to set parameter tier for pushsecrets Jun 17, 2024
@vsantos vsantos changed the title draft: feat(parameterstore): add support to set parameter tier for pushsecrets feat(parameterstore): add support to set parameter tier for pushsecrets Jun 17, 2024
@vsantos vsantos marked this pull request as draft June 17, 2024 03:01
@vsantos vsantos force-pushed the feat/parametertier_pushsecrets_3422 branch 2 times, most recently from 6609c5e to 6728032 Compare June 17, 2024 03:19
Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SecureString for PushString to AWS Parameter Store
1 participant