-
-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parameterstore): add support to set parameter tier for pushsecrets #3581
Draft
vsantos
wants to merge
9
commits into
external-secrets:main
Choose a base branch
from
vsantos:feat/parametertier_pushsecrets_3422
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(parameterstore): add support to set parameter tier for pushsecrets #3581
vsantos
wants to merge
9
commits into
external-secrets:main
from
vsantos:feat/parametertier_pushsecrets_3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Santos <vsantos.py@gmail.com>
/ok-to-test sha=654c946e |
…tos/external-secrets into feat/parametertier_pushsecrets_3422
6609c5e
to
6728032
Compare
|
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Currently, we don't have the option to set which parameter tier to use for the AWS parameter store, and as a result, all secrets are stored using the default tier
Standard
. This PR adds the possibility to work with parameter tierAdvanced
and all its policies.Related Issue
Fixes #3422
Checklist
git commit --signoff
make test
make reviewable