Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: parameter store should be called only once #3584

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Jun 14, 2024

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #3436

Proposed Changes

How do you like to solve the issue and why?

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@Skarlso Skarlso requested a review from a team as a code owner June 14, 2024 07:46
@Skarlso Skarlso requested a review from knelasevero June 14, 2024 07:46
@Skarlso Skarlso changed the title fix: parameter store should be called only once ref: parameter store should be called only once Jun 14, 2024
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@moolen moolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Skarlso Skarlso merged commit ac0eaed into external-secrets:main Jun 15, 2024
16 checks passed
Bude8 pushed a commit to Bude8/external-secrets that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS SM PushSecret creates new version w/ every refresh cycle with secretPushFormat "string"
2 participants