Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Akeyless provider #475

Merged
merged 15 commits into from
Nov 16, 2021
Merged

Conversation

renanaAkeyless
Copy link
Contributor

Add Akeyless provider
support getting your secrets from akeyless

Copy link
Contributor

@paul-the-alien paul-the-alien bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.

Useful commands:

  • make fmt: Formats the code
  • make check-diff: Ensures the branch is clean
  • make reviewable: Ensures a PR is ready for review

@renanaAkeyless renanaAkeyless marked this pull request as draft November 8, 2021 11:37
@renanaAkeyless renanaAkeyless marked this pull request as ready for review November 8, 2021 12:38
@renanaAkeyless renanaAkeyless mentioned this pull request Nov 9, 2021
@renanaAkeyless
Copy link
Contributor Author

@knelasevero @moolen
can you please take a look at my PR
thanks :)

@knelasevero
Copy link
Member

/ok-to-test

e2e/run.sh Outdated Show resolved Hide resolved
@knelasevero
Copy link
Member

/ok-to-test

@knelasevero
Copy link
Member

/ok-to-test

@knelasevero
Copy link
Member

Can you rebase with main branch please?

@knelasevero
Copy link
Member

/ok-to-test

1 similar comment
@knelasevero
Copy link
Member

/ok-to-test

@knelasevero
Copy link
Member

/ok-to-test

Co-authored-by: Lucas Severo Alves <lucassalves65@gmail.com>
Co-authored-by: Lucas Severo Alves <lucassalves65@gmail.com>
@knelasevero
Copy link
Member

/approve

@OriMankali
Copy link

When is this expected to be merged?

@knelasevero
Copy link
Member

I want to manually test the workflow on the docs one time before merging. I did not have the time to do that yet.

@renanaAkeyless
Copy link
Contributor Author

@knelasevero I can help you test it (with credentials and secret-name). you can PM me for details

@knelasevero
Copy link
Member

@renanaAkeyless thanks a lot for the contribution, I think we are all good with this working like a charm.

Can you also add the docs in https://github.com/external-secrets/external-secrets/blob/main/hack/api-docs/mkdocs.yml?

you can check docs locally with make docs, and make serve-docs

@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@renanaAkeyless
Copy link
Contributor Author

@knelasevero thanks :) i have updated the documentation.

@knelasevero knelasevero merged commit 2c07e7d into external-secrets:main Nov 16, 2021
@adyb-fj-cns
Copy link

The CRDs in the helm chart dont appear to be fully updated. The Cluster Secret Store and Secret Store Providers dont look like they have AKeyless listed, however the external secret does

@moolen
Copy link
Member

moolen commented Nov 17, 2021

@adyb-fj-cns it hasn't been released yet, CRDs will be up to date with the next release.

@adyb-fj-cns
Copy link

adyb-fj-cns commented Nov 17, 2021

Ah ok. Perhaps that could be noted in the live documentation as it gives the impression it was released, particularly as some of the CRDS have already been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants