-
-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Akeyless provider #475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.
Useful commands:
make fmt
: Formats the codemake check-diff
: Ensures the branch is cleanmake reviewable
: Ensures a PR is ready for review
@knelasevero @moolen |
/ok-to-test |
/ok-to-test |
/ok-to-test |
Can you rebase with main branch please? |
/ok-to-test |
1 similar comment
/ok-to-test |
/ok-to-test |
Co-authored-by: Lucas Severo Alves <lucassalves65@gmail.com>
Co-authored-by: Lucas Severo Alves <lucassalves65@gmail.com>
/approve |
When is this expected to be merged? |
I want to manually test the workflow on the docs one time before merging. I did not have the time to do that yet. |
@knelasevero I can help you test it (with credentials and secret-name). you can PM me for details |
@renanaAkeyless thanks a lot for the contribution, I think we are all good with this working like a charm. Can you also add the docs in https://github.com/external-secrets/external-secrets/blob/main/hack/api-docs/mkdocs.yml? you can check docs locally with |
Kudos, SonarCloud Quality Gate passed! |
@knelasevero thanks :) i have updated the documentation. |
The CRDs in the helm chart dont appear to be fully updated. The Cluster Secret Store and Secret Store Providers dont look like they have AKeyless listed, however the external secret does |
@adyb-fj-cns it hasn't been released yet, CRDs will be up to date with the next release. |
Ah ok. Perhaps that could be noted in the live documentation as it gives the impression it was released, particularly as some of the CRDS have already been updated |
Add Akeyless provider
support getting your secrets from akeyless