Add provider - senhasegura DevOps Secrets Management (DSM) #830
Conversation
…eploy/crds/bundle.yaml
…external-secrets into feature/provider-senhasegura-dsm
![paul-the-alien[bot]](https://avatars.githubusercontent.com/in/83809?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.
Useful commands:
make fmt: Formats the codemake check-diff: Ensures the branch is cleanmake reviewable: Ensures a PR is ready for review
|
Thanks @lfraga! I did not know about this provider. We are a bit worried about starting to add too many providers to our list, and with that, keep increasing the maintenance load. With that said, I want to ask you, can we count on you to respond to inquiries regarding this provider? Just cause we had some people contributing big things in the beginning and vanishing after a while :) Also, if we need to test something, do you have an account handy to test it? If you could include a bit more info about how to create the secret and all that in the docs would be also nice! Thanks again for the contribution! |
|
Hi @knelasevero thanks for your reply Yes, I can help with maintenance and questions about the senhasegura provider, I've been using ESO and senhasegura for a while I'll add details in provider docs About tests, do you have a reference guide to help me create the mocking for tests ? |
|
Thanks for you review, I will work on that and update the PR |
|
Hey @lfraga just wanted to check your availability to finish this PR :) |
Hey @knelasevero , yes i'm available and working on this PR locally, thanks :) |
lfraga
force-pushed
the
feature/provider-senhasegura-dsm
branch
from
1650dfe
to
c0c1e98
Compare
…ra DSM and adjustments by Code Review
|
Hey @gusfcarvalho and @knelasevero , could you review again? I made the requested implementations/fixes, added improvements in the documentation, provider tests and other minor changes. I believe the only pending task is mock for tests non-provider (go pkg dsm and auth), right ? |
Hi @knelasevero , I have several accounts on senhasegura that can be used to test DSM, tomorrow I'll send in another location to you and @gusfcarvalho details about authentication parameters 😉 (post auth info here is not a good idea) |
🥳 Nice! If you wanna use an ots service (+ instant messaging) to send it to one of us: https://ots.uncloud.do/ Are you on kubernetes slack? |
Co-authored-by: Lucas Severo Alves <lucassalves65@gmail.com>
|
(Not mandatory) We have an Automatically generated change log, (that sometimes we manually edit). Would you please squash some of your intermediary commits so we have them showing up cleanly in the change log? |
|
Kudos, SonarCloud Quality Gate passed!
|
Yeap @knelasevero , I had a lot of conflicts during the traditional rebase and I decided to create a new PR with the exact same content as this one, but with a clean commit history New PR: #1075 Closing this PR |
Add senhasegura DevOps Secrets Management (DSM) provider
Let me know if I missed something in the provider implementation