Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

AWS Region should be required #51

Closed
kenske opened this issue Apr 30, 2019 · 1 comment
Closed

AWS Region should be required #51

kenske opened this issue Apr 30, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@kenske
Copy link
Contributor

kenske commented Apr 30, 2019

The config defaults to us-west-2 for the AWS region which seems arbitrary and caused some pain while troubleshooting. Instead, the AWS region should be set explicitly in the deployment. The documentation should be updated to specify where to modify the value if needed.
@davidholsgrove davidholsgrove mentioned this issue May 1, 2019
Closed
@JacopoDaeli JacopoDaeli added the bug Something isn't working label May 1, 2019
@JacopoDaeli JacopoDaeli mentioned this issue May 1, 2019
Merged
@JacopoDaeli
Copy link
Contributor

JacopoDaeli commented May 1, 2019 •
edited

I created a PR to fix this issue. Adding a helm chart is going to be the next step for simplifying how people can run the daemon with custom config.

@JacopoDaeli JacopoDaeli mentioned this issue May 1, 2019
Merged
davidholsgrove added a commit to biarri/kubernetes-external-secrets that referenced this issue May 2, 2019
@davidholsgrove
Update AWS_REGION to AWS_DEFAULT_REGION after external-secrets#51
25ed733
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kenske @JacopoDaeli