-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Black and Isort to maintain the repository by following python conventions #71
Comments
@extinctsion If you think, this as a needed feature, please assign the issue to me. Would like to work on this issue |
Can you explain a bit what is isort and black for maintaining this repo? |
Pls help us identify the requirements then I'll assign you this issue. |
I can see that the files are not intended properly and some are violating
python standing spacing policies. When we add black to the project we can
make sure that it is following those standards and we can also add a check
in GitHub actions. What do you think?
…On Sun, 22 Oct 2023, 22:17 Aditya Sharma, ***@***.***> wrote:
Pls help us identify the requirements then I'll assign you this issue.
—
Reply to this email directly, view it on GitHub
<#71 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARGXF2RGM7BSHJDVWWCI4R3YAVE2ZAVCNFSM6AAAAAA6K5L3G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGE2DCNBWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Still not clear 😅. Can you give some links to read and understand or have u implemented it before? Pls share it here. |
Sure. Find the link below
https://pypi.org/project/black/
…On Sun, 22 Oct 2023, 23:05 Aditya Sharma, ***@***.***> wrote:
Still not clear 😅. Can you give some links to read and understand or have
u implemented it before? Pls share it here.
—
Reply to this email directly, view it on GitHub
<#71 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARGXF2VCO6JQDULJDDBN7DDYAVKNPAVCNFSM6AAAAAA6K5L3G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGE2TGNBTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Yea, I also searched about it and I think it should be include in this repo. Thanks for giving such amazing idea. |
You're welcome! Please assign me this issue. I will start to work on it
…On Sun, 22 Oct 2023, 23:39 Aditya Sharma, ***@***.***> wrote:
Yea, I also searched about it and I think it should be include in this
repo. Thanks for giving such amazing idea.
—
Reply to this email directly, view it on GitHub
<#71 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARGXF2S4HVJFDI3V7NRHRK3YAVOOJAVCNFSM6AAAAAA6K5L3G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGE3DCMBSGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sure. |
Added the PR #74, please review |
Adding Black and Isort to maintain the repository by following python conventions
The text was updated successfully, but these errors were encountered: