-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve usability of manifest types #124
Conversation
nice - just dropping a note to remind us that we will also need to update: and the graphic that @bhelx generated. ben, what did you use to make that? |
I believe it was this: https://jlblcc.github.io/json-schema-viewer/ There is probably a way to render it in the docs. |
Since we've committed to the API, can we do this in a backwards compatible way? or save it for 1.0? |
If we're going to make some changes like this, there's another I'd like to consider in the HttpRequest type: |
This PR should be backward compatible, with the old names marked as deprecated @nilslice - I will add |
I just realized the |
Added a commit to include similar name changes throughout the SDKs. Figure we should be consistent. This breaks backward-compatibility though, so we should discuss. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you're ok with it @zshipko
ManifestWasm
toWasm
ManifestMemory
toMemoryOptions
ManifestWasm
andManifestMemory
have been marked as deprecatedMemoryOptions::max_pages
toMemoryOptions::max
in serde specification