Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add helper functions for working with input/output of host functions as bytes #240

Merged
merged 10 commits into from
Jan 27, 2023
Merged

feat: add helper functions for working with input/output of host functions as bytes #240

merged 10 commits into from
Jan 27, 2023

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Jan 24, 2023

No description provided.

bhelx
bhelx previously approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged. I'll follow up with the types in python. I think we need them in a few more places.

@zshipko
Copy link
Contributor Author

zshipko commented Jan 27, 2023

Oops, I didn't see that last comment and ended up adding the Python types. I will merge once CI passes.

@zshipko zshipko merged commit bacb44b into main Jan 27, 2023
@zshipko zshipko deleted the host-function-helpers branch January 27, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhelx bhelx bhelx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zshipko @bhelx