Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(dotnet): publish nuget packages for all supported environments #523

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

mhmd-azeez
Copy link
Collaborator

@mhmd-azeez mhmd-azeez commented Oct 17, 2023

NuGet supports the distribution of native binaries. We already provide a win-x64 package, this PR adds packages for the other environments. We will be publishing these NuGet packages:

  • Extism.runtime.linux-arm64
  • Extism.runtime.linux-musl-arm64
  • Extism.runtime.linux-x64
  • Extism.runtime.osx-arm64
  • Extism.runtime.osx-x64
  • Extism.runtime.win-x64 (msvc)
  • Extism.runtime.all -> this is a meta package that referencs all other packages. The idea is, in the getting started guides we instruct the user to take a dependency on Extism.Sdk and Extism.runtime.all. This will make sure their apps work on all supported operating systems automatically. Otherwise, they can just take a dependency on what they care about

This PR also adds a dependency on MinVer which make sure packages are automatically versioned based on git tags.

Related to #486

@mhmd-azeez
Copy link
Collaborator Author

@chrisdickinson I didn't put it in release.yml yet because I wanted to publish it once to see if it works well before messing with all the other releases. But can create a new PR that adds this as a step there afterwards

Copy link
Contributor

@chrisdickinson chrisdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Landing this and following up by splitting the dotnet pack creation from the dotnet nuget push steps is perfect.

@mhmd-azeez mhmd-azeez merged commit 2c82b92 into main Oct 18, 2023
3 checks passed
@mhmd-azeez mhmd-azeez deleted the ci/nuget-native-packages branch October 18, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants