fix: nuget packing in release-dotnet-native.yaml #524
Conversation
mhmd-azeez
changed the title
|
|
|
The pipeline works now :) https://www.nuget.org/packages/Extism.runtime.all#dependencies-body-tab |
| - name: Pack NuGet packages | ||
| run: | | ||
| find ./dotnet/nuget -type f -name "*.csproj" -exec dotnet pack {} -o release-artifacts \; | ||
|
|
||
| - name: Publish NuGet packages | ||
| run: | | ||
| dotnet pack .\dotnet\nuget\Nuget.sln -o release-artifacts | ||
| dotnet nuget push --source https://api.nuget.org/v3/index.json ./release-artifacts/*.nupkg --api-key ${{ secrets.NUGET_API_KEY }} |
There was a problem hiding this comment.
Great work! Landing this and following up by splitting the dotnet pack creation from the dotnet nuget push steps is perfect.
Is this what you meant?
There was a problem hiding this comment.
Sorry I'm late in responding! Not quite – I meant splitting the dotnet pack step into a separate workflow that creates a draft GitHub release on push to main or tag creation, then modifying the release workflow that triggers on GitHub release to dotnet nuget push the artifact from the release. (Splitting out these steps moves us in this direction, though – the PR LGTM!)
|
Let's merge this PR and then I will try to integrate it into the main flow |
| - name: Pack NuGet packages | ||
| run: | | ||
| find ./dotnet/nuget -type f -name "*.csproj" -exec dotnet pack {} -o release-artifacts \; | ||
|
|
||
| - name: Publish NuGet packages | ||
| run: | | ||
| dotnet pack .\dotnet\nuget\Nuget.sln -o release-artifacts | ||
| dotnet nuget push --source https://api.nuget.org/v3/index.json ./release-artifacts/*.nupkg --api-key ${{ secrets.NUGET_API_KEY }} |
There was a problem hiding this comment.
Sorry I'm late in responding! Not quite – I meant splitting the dotnet pack step into a separate workflow that creates a draft GitHub release on push to main or tag creation, then modifying the release workflow that triggers on GitHub release to dotnet nuget push the artifact from the release. (Splitting out these steps moves us in this direction, though – the PR LGTM!)
|
@chrisdickinson perfect, I will open a separate PR |
Seems like there are some weird subtle differences between Windows and Linux