Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: release extism.dll.lib and extism.dll.a #633

Merged
merged 6 commits into from
Dec 13, 2023
Merged

ci: release extism.dll.lib and extism.dll.a #633

merged 6 commits into from
Dec 13, 2023

Conversation

mhmd-azeez
Copy link
Collaborator

@mhmd-azeez mhmd-azeez commented Dec 13, 2023 •
edited

Related to #141 and #584
Follow up of #632

@mhmd-azeez
Copy link
Collaborator Author

Here is a sample project that shows this works:
https://github.com/mhmd-azeez/extism-cpp-demo

@mhmd-azeez
Copy link
Collaborator Author

Alright, it seems to be working: https://github.com/extism/extism/actions/runs/7196310260

Only problem is the Set version step which seems to be failing, but this PR hasn't changed that, so not sure what's going on

G4Vi
G4Vi approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@G4Vi G4Vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! At some point we should test building with mingw. It's good to have all the import libraries.

@mhmd-azeez mhmd-azeez mentioned this pull request Dec 13, 2023
Open
3 tasks
chrisdickinson
chrisdickinson approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@chrisdickinson chrisdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work.

chrisdickinson
chrisdickinson approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@chrisdickinson chrisdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github didn't clear my notifications with that last LGTM, so you get two LGTMs from me! 😅

@mhmd-azeez mhmd-azeez merged commit 49e2889 into main Dec 13, 2023
@mhmd-azeez mhmd-azeez deleted the release-dll-lib branch December 13, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdickinson chrisdickinson chrisdickinson approved these changes

@G4Vi G4Vi G4Vi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhmd-azeez @chrisdickinson @G4Vi