fix: give extism_log_drain's param a named type #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a test failure on the python-sdk [1]. (See also [2]). In particular, while maturin creates bindings for `extism_log_drain` on clang platforms, it seems that MSVC cannot generate the required binding information for `ffi.py`. This results in an `extism_sys` wheel whose shared object (in this case, a DLL) contains the `extism_log_drain`, but whose Python FFI bindings don't contain a definition for that function. Naming the function pointer type parameter resolves the issue. [1]: https://github.com/extism/python-sdk/actions/runs/7172934060/job/19669775001#step:9:35 [2]: extism/python-sdk#18 (comment)
chrisdickinson
force-pushed
the
chris/20231215-test-windows-fn-ptr
branch
from
2bff168
to
60bcf43
Compare
zshipko
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a test failure on the python-sdk 1. (See also 2). In particular, while maturin creates bindings for
extism_log_drainon clang platforms, it seems that MSVC cannot generate the required binding information forffi.py. This results in anextism_syswheel whose shared object (in this case, a DLL) contains theextism_log_drain, but whose Python FFI bindings don't contain a definition for that function.Naming the function pointer type parameter resolves the issue. What a strange issue!