Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use quickcheck to test allocations, fix one bug that was uncovered. #662

Merged
merged 4 commits into from
Jan 19, 2024
Merged

feat: Use quickcheck to test allocations, fix one bug that was uncovered. #662

merged 4 commits into from
Jan 19, 2024

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Jan 19, 2024 •
edited
Loading

  • Adds quickcheck tests for alloc/free/load/store from the kernel, I wasn't able to include these in the new wasm-bindgen tests because getrandom isn't available on wasm32-unknown-unknown
  • Fixes a bug in the calculation of how much memory is needed to allocate the next block in the kernel. This bug is triggered when allocating at the end of a page, the size of the MemoryBlock value wasn't being taken in consideration when determining whether or not to call memory.grow

@zshipko zshipko merged commit d5dc9b4 into main Jan 19, 2024
6 checks passed
@zshipko zshipko deleted the quickcheck branch January 19, 2024 21:04
@zshipko zshipko mentioned this pull request Jan 19, 2024
Merged
zshipko added a commit to extism/go-sdk that referenced this pull request Jan 19, 2024
@zshipko
chore: update extism-runtime.wasm (#57)
cfcf586 
For extism/extism#662
@zshipko zshipko mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zshipko