-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creating annotated tag broke #2126
Comments
to be clear
|
@MichaelAug is on this one |
The issue is with gitui/src/components/textinput.rs Lines 421 to 435 in 0ab1ff8
So there's multiple ways to handle this. We could make |
I would do what I did with all other 'known' keystrokes that map to things that are not hugely important to tuit xtarea. Filter them out at the start, you will see a set of skipped keystrokes at the start of the key handling (on the road so I can't point to the specific line) |
@MichaelAug I had a look at #2053 again and remember what happened: the cleaner way to do it is to first react to our local gitui key events and only push down whats not handled into textarea. so I prototyped the same solution for this one: #2139 please pick it up from there:
|
@extrawurst I just saw that you removed the code that filtered out the keystrokes that have special meaning to gitui, but that are safe to not hand to tta
This code in fact made sure that ctrl-a worked OK |
@pm100 I am not sure what you mean, ctrl+a works: |
But ctrla should NOT work. It's has a special meaning to ggitui so I filtered it out and returned as unhandled. That deleted block of code picked out all the special keystrokes that have meaning to gityi text input callers. I lacked the knowledge of who the caller was so could not conditionally filter them out. However all the filtered out strokes were for relatively obscure tta features. I had all this explained way back in the origin nal PR ( a long time ago). I was determined to have minimal impact, so I had no idea who the caller was. I could have filtered out in the caller, or had th caller pass a list of keys that tta should not eat. But that would have been an API change |
@pm100 see the above mentioned commit: the caller filters out what the caller cares about. It is working as expected. If you want to discuss this further feel free to join the discord. This derails this conversation here |
this is how creating annotated tags used to work (before
0.25
):now its broken. i suspect this broke during the transition to textarea in b9a2e13 by @pm100
The text was updated successfully, but these errors were encountered: