Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignoring .gitignore just keeps adding .gitignore in .gitignore #825

Closed
ignatenkobrain opened this issue Jul 24, 2021 · 1 comment · Fixed by #835
Closed

Ignoring .gitignore just keeps adding .gitignore in .gitignore #825

ignatenkobrain opened this issue Jul 24, 2021 · 1 comment · Fixed by #835
Labels
bug Something isn't working
Milestone
v0.17

Comments

@ignatenkobrain
Copy link
Contributor

Describe the bug

I think subject covers it pretty well.

To Reproduce
Steps to reproduce the behavior:

  1. Make sure your repository does not have any .gitignore in it
  2. Ignore any file (so that .gitignore would be created by gitui)
  3. Try to ignore .gitignore
  4. The .gitignore is added to the .gitignore (and if you repeat, it is added infinitely)

Expected behavior

Either ignoring .gitignore would not do anything or throw an error.

Screenshots

image

Context (please complete the following information):

  • OS/Distro + Version: Fedora 35
  • GitUI Version: 0.16.2
  • Rust version: 1.53

Additional context

None.
@extrawurst extrawurst added this to the v0.17 milestone Aug 3, 2021
@extrawurst extrawurst added the bug Something isn't working label Aug 3, 2021
@extrawurst
Copy link
Owner

Screenshot 2021-08-03 at 23 31 13

extrawurst pushed a commit that referenced this issue Aug 3, 2021
do not allow to ignore gitignore (fixes #825)
290131d
@extrawurst extrawurst mentioned this issue Aug 3, 2021
Merged
extrawurst pushed a commit that referenced this issue Aug 3, 2021
do not allow to ignore gitignore (fixes #825)
29f71f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.17
Development

Successfully merging a pull request may close this issue.

do not allow to ignore gitignore extrawurst/gitui
2 participants
@extrawurst @ignatenkobrain