Fix external editor delay. #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Questions:
|
|
please rebase on current master. should fix the CI |
The default polling rate of 1 second causes a 1 second delay when queuing the event to launch the external editor, causing borderline unusable latency. However, a slower polling helps reduce CPU usage (not tested), so let's have a short polling duration as long as there are input events, and slow poll otherwise. Since the external editor among other components (not tested) is always launched in response to an input event, we reduce the latency to ~100ms, which is the fast poll duration.
|
Hi! Just wondering if there's still anything to be done on my end. |
IndianBoy42
pushed a commit
to IndianBoy42/gitui
that referenced
this pull request
Jun 4, 2024
The default polling rate of 1 second causes a 1 second delay when queuing the event to launch the external editor, causing latency. However, a slower polling helps reduce CPU usage, so let's have a short polling duration as long as there are input events, and slow poll otherwise. Since the external editor among other components (not tested) is always launched in response to an input event, we reduce the latency to ~100ms, which is the fast poll duration. Co-authored-by: extrawurst <776816+extrawurst@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default polling rate of 1 second causes a 1 second delay when queuing the event to launch the external editor, causing borderline unusable latency.
However, a slower polling helps reduce CPU usage (not tested), so let's have a short polling duration as long as there are input events, and slow poll otherwise.
Since the external editor among other components (not tested) is always launched in response to an input event, we reduce the latency to ~100ms, which is the fast poll duration.
Fixes #1506.