Feat 1757 add signoff option #1758
Conversation
Signed-off-by Dominik Tacke <tacdom+github@gmail.com>
Signed-off-by: Dominik Tacke <tacdom+github@gmail.com>
Signed-off-by Dominik Tacke <tacdom+github@gmail.com>
Signed-off-by Dominik Tacke <tacdom+github@gmail.com>
Signed-off-by Dominik Tacke <tacdom+github@gmail.com>
There was a problem hiding this comment.
I would like to keep the impact on the asyncgit crate minimal. lets keep the add_sign_off as a pub method we expose and lets make the command just add the sign-off part at commit-msg-edit time. this way its not a mode either. the command just triggers the sign-off addition
Sure thing. Thanks for the remark. I will be off a couple of days. Expect my changes by end of next week latest. |
Signed-off-by Dominik Tacke <tacdom+github@gmail.com>
Signed-off-by Dominik Tacke <tacdom+github@gmail.com>
Signed-off-by Dominik Tacke <tacdom+github@gmail.com>
@extrawurst Hi thanks again for the feedback and for the patience until I found time to address your issues. Please have a look. |
Signed-off-by Dominik Tacke <tacdom+github@gmail.com>
Signed-off-by Dominik Tacke <tacdom+github@gmail.com>
|
LGTM - let's start with a simple version. if you add it twice and forget to clean it its not nice but not a bug right? |
Aboslutely. I would say that putting the sign-off multiple times is rather an inconvenience than a bug. I'd let it like it is. |
| let mut msg = msg.to_owned(); | ||
| if let (Some(user), Some(mail)) = (user, mail) { | ||
| msg.push_str(&format!( | ||
| "\n\nSigned-off-by {user} <{mail}>" |
There was a problem hiding this comment.
There's the : missing after the key of the trailer.
There was a problem hiding this comment.
Reported in #2196.
| ) -> CommandText { | ||
| CommandText::new( | ||
| format!( | ||
| "Sing-off [{}]", |
There was a problem hiding this comment.
@matthiasbeyer this PR is already merged, could you open a PR fixing the typos?
This Pull Request fixes/closes #1757 .
It changes the following:
I followed the checklist:
make checkwithout errors