This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Update AMD module definition to not be anonymous #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
older ember versions don't support anonymous amd modules, and this resolves the issue by naming the module definition and providing an empty dependency array.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older Ember versions don't support anonymous AMD modules, and unfortunately I'm stuck on an older Ember version for now and am not able to import this module due to that. This PR resolves the issue by naming the module definition and providing an empty dependency array, which AFAIK should not be a breaking change (but correct me if I'm wrong).