Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting null body sometimes in cycleDirectionSettings #88

Closed
eyalroz opened this issue Aug 5, 2023 · 1 comment
Closed

Getting null body sometimes in cycleDirectionSettings #88

eyalroz opened this issue Aug 5, 2023 · 1 comment
Assignees
@eyalroz
Labels
bug Something isn't working

Comments

@eyalroz
Copy link
Owner

eyalroz commented Aug 5, 2023 •
edited

On some calls to cycleDirectionSettings() - which I can't yet characterize, the body:

document.getElementById("messagepane").contentDocument.body

... is null. Perhaps we're acting before the document is loaded? Perhaps on something that's not really a document? Perhaps this has to do with repeated keypresses, or tab switches? I don't know.

We'll resolve this - more or less - by checking explicitly and logging the document URL.
@eyalroz eyalroz added the bug Something isn't working label Aug 5, 2023
@eyalroz eyalroz self-assigned this Aug 5, 2023
eyalroz added a commit that referenced this issue Aug 5, 2023
@eyalroz
Fixes #88: Now gracefully handling attempts to cycle the directions o…
f08219e 
…f documents which, somehow, report having no body

Note: Logging such situations with a warning.
@eyalroz eyalroz added compatibility bug Something isn't working and removed bug Something isn't working compatibility labels Aug 6, 2023
eyalroz added a commit that referenced this issue Aug 10, 2023
@eyalroz
Fixes #88: Now gracefully handling attempts to cycle the directions o…
8d60246 
…f documents which, somehow, report having no body

Note: Logging such situations with a warning.
eyalroz added a commit that referenced this issue Aug 17, 2023
@eyalroz
Fixes #88: Now gracefully handling attempts to cycle the directions o…
37dbb62 
…f documents which, somehow, report having no body

Note: Logging such situations with a warning.
@eyalroz
Copy link
Owner Author

eyalroz commented Aug 17, 2023

Resolved for TB 115 and later, at least, via issue #97 .

@eyalroz eyalroz closed this as completed Aug 17, 2023
eyalroz added a commit that referenced this issue Sep 1, 2023
@eyalroz
Fixes #88: Now gracefully handling attempts to cycle the directions o…
e888dbd 
…f documents which, somehow, report having no body

Note: Logging such situations with a warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz