Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct/robustify resolution of cMCParams.mailnewsDecodingType #97

Closed
eyalroz opened this issue Aug 11, 2023 · 0 comments
Closed

Correct/robustify resolution of cMCParams.mailnewsDecodingType #97

eyalroz opened this issue Aug 11, 2023 · 0 comments
Assignees
Labels
bug Something isn't working compatibility

Comments

@eyalroz
Copy link
Owner

eyalroz commented Aug 11, 2023

We are sometimes getting cMCParams.mailnewsDecodingType wrong. Let's be more robust about resolving it.

@eyalroz eyalroz self-assigned this Aug 11, 2023
eyalroz added a commit that referenced this issue Aug 11, 2023
… preferred charset or UTF-8)

* More robustly handling failures to resolve the mailnewsDecodingType
* Removed the commented-out scancode printing code
* Split `matchInText()` into two functions: `textMatches()` and `getTextMatchUniformity()`, with the latter returning two booleans in an object, and the former just one.
* Renamed some local variables.
* Comment corrections, especially w.r.t. TB 91 and later behavior (i.e. inability to force charset)
* Now consistently returning a boolean from `fixLoadedMessageCharsetIssues()`
@eyalroz eyalroz added this to the Thunderbird 115 Compatibility milestone Aug 12, 2023
@eyalroz eyalroz added bug Something isn't working compatibility labels Aug 12, 2023
eyalroz added a commit that referenced this issue Aug 14, 2023
… preferred charset or UTF-8)

* More robustly handling failures to resolve the mailnewsDecodingType
* Removed the commented-out scancode printing code
* Split `matchInText()` into two functions: `textMatches()` and `getTextMatchUniformity()`, with the latter returning two booleans in an object, and the former just one.
* Renamed some local variables.
* Comment corrections, especially w.r.t. TB 91 and later behavior (i.e. inability to force charset)
* Now consistently returning a boolean from `fixLoadedMessageCharsetIssues()`
@eyalroz eyalroz closed this as completed in a12055a Sep 1, 2023
eyalroz added a commit that referenced this issue Sep 1, 2023
… preferred charset or UTF-8)

* More robustly handling failures to resolve the mailnewsDecodingType
* Removed the commented-out scancode printing code
* Split `matchInText()` into two functions: `textMatches()` and `getTextMatchUniformity()`, with the latter returning two booleans in an object, and the former just one.
* Renamed some local variables.
* Comment corrections, especially w.r.t. TB 91 and later behavior (i.e. inability to force charset)
* Now consistently returning a boolean from `fixLoadedMessageCharsetIssues()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility
Projects
None yet
Development

No branches or pull requests

1 participant