Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "stream ids" and "event ids" into stream and event handles #280

Closed
eyalroz opened this issue Nov 30, 2021 · 0 comments
Closed

Rename "stream ids" and "event ids" into stream and event handles #280

eyalroz opened this issue Nov 30, 2021 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Nov 30, 2021

Devices have numeric IDs ; streams and events actually use pointers to allocated structures, which are made (somewhat) opaque via type aliasing. We should not call these IDs... using "handles" is probably more appropriate.

This is relevant to both the develop and driver-wrapper branches.
@eyalroz eyalroz added the task label Nov 30, 2021
@eyalroz eyalroz self-assigned this Nov 30, 2021
eyalroz added a commit that referenced this issue Dec 8, 2021
@eyalroz
Fixes #280, #281:
54b1268 
* Now using "event handle", "stream handle" rather than "event id", "stream id" respectively.
* Implemented `detail_::identify()` variants for streams and events, and placed them together with the device identifier in `error.hpp`.
eyalroz added a commit that referenced this issue Dec 8, 2021
@eyalroz
Fixes #280, #283:
53adacb 
* Now using "event handle", "stream handle" rather than "event id", "stream id" respectively.
* Implemented `detail_::identify()` variants for streams and events, and placed them together with the device identifier in `error.hpp`.
eyalroz added a commit that referenced this issue Dec 10, 2021
@eyalroz
Fixes #280, #283:
d66a7ba 
* Now using "event handle", "stream handle" rather than "event id", "stream id" respectively.
* Implemented `detail_::identify()` variants for streams and events, and placed them together with the device identifier in `error.hpp`.
eyalroz added a commit that referenced this issue Jan 14, 2022
@eyalroz
Fixes #280, #283:
08d2c6c 
* Now using "event handle", "stream handle" rather than "event id", "stream id" respectively.
* Implemented `detail_::identify()` variants for streams and events, and placed them together with the device identifier in `error.hpp`.
@eyalroz eyalroz closed this as completed Jan 14, 2022
@pauleonix pauleonix mentioned this issue Feb 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz