Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out device, event, stream etc. identification code #283

Closed
eyalroz opened this issue Dec 8, 2021 · 0 comments
Closed

Factor out device, event, stream etc. identification code #283

eyalroz opened this issue Dec 8, 2021 · 0 comments

Comments

@eyalroz
Copy link
Owner

eyalroz commented Dec 8, 2021

We currently do a lot of string generation of the form

:std::string("stream ") + cuda::detail_::ptr_as_hex(handle) + " on device " + std::to_string(device_id);

and this is quite redundant. Let us, instead, have identify() functions, with variants depending on the information we have about these objects, within the detail_ namespace. We already have this, albeit imperfectly, on the driver-wrappers branch.

@eyalroz eyalroz added the task label Dec 8, 2021
@eyalroz eyalroz self-assigned this Dec 8, 2021
eyalroz added a commit that referenced this issue Dec 8, 2021
* Now using "event handle", "stream handle" rather than "event id", "stream id" respectively.
* Implemented `detail_::identify()` variants for streams and events, and placed them together with the device identifier in `error.hpp`.
eyalroz added a commit that referenced this issue Dec 10, 2021
* Now using "event handle", "stream handle" rather than "event id", "stream id" respectively.
* Implemented `detail_::identify()` variants for streams and events, and placed them together with the device identifier in `error.hpp`.
eyalroz added a commit that referenced this issue Jan 14, 2022
* Now using "event handle", "stream handle" rather than "event id", "stream id" respectively.
* Implemented `detail_::identify()` variants for streams and events, and placed them together with the device identifier in `error.hpp`.
@eyalroz eyalroz closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant