Make the nvtx library header-only #307
Assignees
Labels
Comments
eyalroz
added a commit
that referenced
this issue
Mar 25, 2022
…nly. * Dropped `profiling.cpp` - all necessary code is now in `profiling.hpp`. * No longer taking `std::string`'s for messages - there's no need to force the user to construct such strings. * Templated all functions taking strings to take either a `const char*` or `const wchar_t *`. * Some duplicate code factor-out and other clean-up. * Added an example program which uses some of the profiling functionality: `other/vectorAdd_profiled`.
eyalroz
added a commit
that referenced
this issue
Mar 25, 2022
…nly. * Dropped `profiling.cpp` - all necessary code is now in `profiling.hpp`. * No longer taking `std::string`'s for messages - there's no need to force the user to construct such strings. * Templated all functions taking strings to take either a `const char*` or `const wchar_t *`. * Some duplicate code factor-out and other clean-up. * Added an example program which uses some of the profiling functionality: `other/vectorAdd_profiled`.
eyalroz
added a commit
that referenced
this issue
Mar 25, 2022
…nly. * Dropped `profiling.cpp` - all necessary code is now in `profiling.hpp`. * No longer taking `std::string`'s for messages - there's no need to force the user to construct such strings. * Templated all functions taking strings to take either a `const char*` or `const wchar_t *`. * Some duplicate code factor-out and other clean-up. * Added an example program which uses some of the profiling functionality: `other/vectorAdd_profiled`.
eyalroz
added a commit
that referenced
this issue
Mar 26, 2022
…nly. * Dropped `profiling.cpp` - all necessary code is now in `profiling.hpp`. * No longer taking `std::string`'s for messages - there's no need to force the user to construct such strings. * Templated all functions taking strings to take either a `const char*` or `const wchar_t *`. * Some duplicate code factor-out and other clean-up. * Added an example program which uses some of the profiling functionality: `other/vectorAdd_profiled`.
eyalroz
added a commit
that referenced
this issue
Jun 20, 2022
…nly. * Dropped `profiling.cpp` - all necessary code is now in `profiling.hpp`. * No longer taking `std::string`'s for messages - there's no need to force the user to construct such strings. * Templated all functions taking strings to take either a `const char*` or `const wchar_t *`. * Some duplicate code factor-out and other clean-up. * Added an example program which uses some of the profiling functionality: `other/vectorAdd_profiled`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The argument in favor of having nvtx an actual library, rather than header-only, is that it allows compilation of code using nvtx without including pthreads etc. But - is that so useful? You still need to link against it. Let's just go full header-only, if possible.
The text was updated successfully, but these errors were encountered: