Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In NVTX, be willing to accept both narrow and wide character strings #308

Closed
eyalroz opened this issue Mar 25, 2022 · 0 comments
Closed

In NVTX, be willing to accept both narrow and wide character strings #308

eyalroz opened this issue Mar 25, 2022 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task
Milestone
Full NVTX v3 support

Comments

@eyalroz
Copy link
Owner

eyalroz commented Mar 25, 2022

NVTX ranges and points can take char names and wchar_t names; we should support both.
@eyalroz eyalroz added the task label Mar 25, 2022
@eyalroz eyalroz self-assigned this Mar 25, 2022
eyalroz added a commit that referenced this issue Mar 25, 2022
@eyalroz
Fixes #307, #308: The nvtx component of the library is now header-o…
dcde557 
…nly.

* Dropped `profiling.cpp` - all necessary code is now in `profiling.hpp`.
* No longer taking `std::string`'s for messages - there's no need to force the user to construct such strings.
* Templated all functions taking strings to take either a `const char*` or `const wchar_t *`.
* Some duplicate code factor-out and other clean-up.
* Added an example program which uses some of the profiling functionality: `other/vectorAdd_profiled`.
eyalroz added a commit that referenced this issue Mar 25, 2022
@eyalroz
Fixes #307, #308: The nvtx component of the library is now header-o…
b517e5f 
…nly.

* Dropped `profiling.cpp` - all necessary code is now in `profiling.hpp`.
* No longer taking `std::string`'s for messages - there's no need to force the user to construct such strings.
* Templated all functions taking strings to take either a `const char*` or `const wchar_t *`.
* Some duplicate code factor-out and other clean-up.
* Added an example program which uses some of the profiling functionality: `other/vectorAdd_profiled`.
eyalroz added a commit that referenced this issue Mar 25, 2022
@eyalroz
Fixes #307, #308: The nvtx component of the library is now header-o…
33104f9 
…nly.

* Dropped `profiling.cpp` - all necessary code is now in `profiling.hpp`.
* No longer taking `std::string`'s for messages - there's no need to force the user to construct such strings.
* Templated all functions taking strings to take either a `const char*` or `const wchar_t *`.
* Some duplicate code factor-out and other clean-up.
* Added an example program which uses some of the profiling functionality: `other/vectorAdd_profiled`.
eyalroz added a commit that referenced this issue Mar 26, 2022
@eyalroz
Fixes #307, #308: The nvtx component of the library is now header-o…
a1c1e1b 
…nly.

* Dropped `profiling.cpp` - all necessary code is now in `profiling.hpp`.
* No longer taking `std::string`'s for messages - there's no need to force the user to construct such strings.
* Templated all functions taking strings to take either a `const char*` or `const wchar_t *`.
* Some duplicate code factor-out and other clean-up.
* Added an example program which uses some of the profiling functionality: `other/vectorAdd_profiled`.
eyalroz added a commit that referenced this issue Mar 26, 2022
@eyalroz
Fixes #307, #308: The nvtx component of the library is now header-o…
808464a 
…nly.

* Dropped `profiling.cpp` - all necessary code is now in `profiling.hpp`.
* No longer taking `std::string`'s for messages - there's no need to force the user to construct such strings.
* Templated all functions taking strings to take either a `const char*` or `const wchar_t *`.
* Some duplicate code factor-out and other clean-up.
* Added an example program which uses some of the profiling functionality: `other/vectorAdd_profiled`.
@eyalroz eyalroz added this to the Full NVTX v3 support milestone Mar 26, 2022
@eyalroz eyalroz closed this as completed May 16, 2022
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #307, #308: The nvtx component of the library is now header-o…
527ba7d 
…nly.

* Dropped `profiling.cpp` - all necessary code is now in `profiling.hpp`.
* No longer taking `std::string`'s for messages - there's no need to force the user to construct such strings.
* Templated all functions taking strings to take either a `const char*` or `const wchar_t *`.
* Some duplicate code factor-out and other clean-up.
* Added an example program which uses some of the profiling functionality: `other/vectorAdd_profiled`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
Full NVTX v3 support
Development

No branches or pull requests
1 participant
@eyalroz