Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have all targets mark dependencies of CUDA library dependencies which NVIDIA ignores #583

Closed
eyalroz opened this issue Feb 8, 2024 · 0 comments
Closed

Have all targets mark dependencies of CUDA library dependencies which NVIDIA ignores #583

eyalroz opened this issue Feb 8, 2024 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Feb 8, 2024 •
edited
Loading

It seems that libcuda and libcudart both currently depend on libdl, libphtreads and librt; and libcuda on libm. CMake doesn't seem to mark these dependencies, so - let's mark them ourselves.
@eyalroz eyalroz added the task label Feb 8, 2024
@eyalroz eyalroz self-assigned this Feb 8, 2024
@eyalroz eyalroz changed the title Have all targets depend on CMAKE_DL_LIBS Have all targets mark dependencies of CUDA library dependencies which NVIDIA ignores Feb 8, 2024
eyalroz pushed a commit that referenced this issue Feb 8, 2024
Fixes #583: All wrapper library targets now depend on librt (on Linux…
234676a 
…), libm, a threads library (pthreads on Linux) and the dynamic linking library (libdl on Linux)
eyalroz pushed a commit that referenced this issue Feb 8, 2024
@eyalroz
Fixes #583: All wrapper library targets now depend on librt (on Linux…
126d63c 
…), libm, a threads library (pthreads on Linux) and the dynamic linking library (libdl on Linux)
eyalroz pushed a commit that referenced this issue Feb 9, 2024
@eyalroz
Fixes #583: All wrapper library targets now depend on librt (on Linux…
56fe4b1 
…), libm, a threads library (pthreads on Linux) and the dynamic linking library (libdl on Linux)
eyalroz pushed a commit that referenced this issue Feb 9, 2024
@eyalroz
Fixes #583: All wrapper library targets now depend on librt (on Linux…
0697eb2 
…), libm, a threads library (pthreads on Linux) and the dynamic linking library (libdl on Linux)
eyalroz pushed a commit that referenced this issue Feb 9, 2024
@eyalroz
Fixes #583: All wrapper library targets now depend on librt (on Linux…
ad02c60 
…), libm, a threads library (pthreads on Linux) and the dynamic linking library (libdl on Linux)
eyalroz pushed a commit that referenced this issue Feb 29, 2024
@eyalroz
Fixes #583: All wrapper library targets now depend on librt (on Linux…
5f7aaa1 
…), libm, a threads library (pthreads on Linux) and the dynamic linking library (libdl on Linux)
@eyalroz eyalroz closed this as completed in 8ca9b6c Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz