Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't instantiate neutral value for non-integer types #72

Open
eyalroz opened this issue May 11, 2020 · 0 comments
Open

Can't instantiate neutral value for non-integer types #72

eyalroz opened this issue May 11, 2020 · 0 comments
Assignees
@eyalroz
Labels
bug Something isn't working fixed on development A fix for this issue has been committed to the development branch

Comments

@eyalroz
Copy link
Owner

eyalroz commented May 11, 2020

I mis-designed the reduction and scan functions to take a neutral value as a template parameter; this works for integral types, not for floating-point types (until C++20).

For the time being, this template isn't even that interesting/useful. So - for now we'll just drop it. This will also mean an update of 0.1.0 to 0.1.1.
@eyalroz eyalroz self-assigned this May 11, 2020
@eyalroz eyalroz added the bug Something isn't working label May 11, 2020
eyalroz pushed a commit that referenced this issue May 11, 2020
Fixes #72.
4527bcc 
* Dropped `NeutralValue` template parameter to reduction, scan and scan-and-reduce functions.
@eyalroz eyalroz added the fixed on development A fix for this issue has been committed to the development branch label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug Something isn't working fixed on development A fix for this issue has been committed to the development branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz