Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearrange standard header inclusions #145

Closed
eyalroz opened this issue Oct 14, 2022 · 0 comments
Closed

Rearrange standard header inclusions #145

eyalroz opened this issue Oct 14, 2022 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Oct 14, 2022

  1. We include stdbool.h and stdint.h unnecessarily in C++.
  2. We include stdbool.h and stdint.h twice in C.

Let's not do that.
@eyalroz eyalroz self-assigned this Oct 14, 2022
@eyalroz eyalroz added task resolved-on-develop A changeset fixing this issue has been commiutted to the development branch labels Oct 14, 2022
eyalroz added a commit that referenced this issue Oct 17, 2022
@eyalroz
Fixes #144, fixes #145: Rearranged system header inclusion in `printf…
f8ed5a9 
….c` and removes its excessive use of extern "C".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz