Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant extern "C" from the definitions in printf.c #144

Closed
eyalroz opened this issue Oct 14, 2022 · 0 comments
Closed

Remove redundant extern "C" from the definitions in printf.c #144

eyalroz opened this issue Oct 14, 2022 · 0 comments
Assignees
@eyalroz
Labels
platform-incompatibility The library is making assumptions causing it to fail on platforms where they do not hold. task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Oct 14, 2022

When using the library in C++, only the printf.h definitions need to be surrounded by extern "C" (see also this SO question). Apparently, some compilers (e.g. clang on Mac) seem to have trouble with definitions surrounded by it. So - let's remove it.
@eyalroz eyalroz added task platform-incompatibility The library is making assumptions causing it to fail on platforms where they do not hold. labels Oct 14, 2022
@eyalroz eyalroz self-assigned this Oct 14, 2022
eyalroz added a commit that referenced this issue Oct 17, 2022
@eyalroz
Fixes #144, fixes #145: Rearranged system header inclusion in `printf…
f8ed5a9 
….c` and removes its excessive use of extern "C".
eyalroz added a commit that referenced this issue Jul 19, 2024
@eyalroz
Fixes #144, fixes #145: Rearranged system header inclusion in `printf…
f4a7579 
….c` and removes its excessive use of extern "C".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
platform-incompatibility The library is making assumptions causing it to fail on platforms where they do not hold. task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz