Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run miri on CI #82

Closed
wants to merge 5 commits into from
Closed

Run miri on CI #82

wants to merge 5 commits into from

Conversation

TimDiekmann
Copy link
Contributor

As mentioned in #81 here is a small PR disabling the tests, which are not compatible with miri. Also, I found a few other mem::transmutes. The job will run in the CI, you might want to mark it as required 🙂

@TimDiekmann
Copy link
Contributor Author

Interestingly, the latest nightly have even more rules for stacked borrows. I tested the branch with 2022-06-23 and it worked. Will investigate it further.

@TimDiekmann TimDiekmann marked this pull request as draft July 7, 2022 22:46
@TimDiekmann
Copy link
Contributor Author

I tested the latest nightly with anyhow and error-stack, too. As you linked in my other PR, since recently, more work has to be done: dtolnay/anyhow#134.

@TimDiekmann
Copy link
Contributor Author

Replacing Box with NonNull in error-stack works. However, I sadly don't have enough time to adjust everything for eyre as internally, eyre looks quite different. However, if you basically apply the linked PR everything should work. 🙂

@yaahc
Copy link
Collaborator

yaahc commented Jul 8, 2022

Yeah, that's the PR mentioned in #59 and doing that bit of work is the thing I've been dragging my feet on for ages hoping someone else would come along to do :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants