Grid view is broken

[cafkafk]

Running --grid with the latest git version of zetta is broken on my machine.

E.g. by doing cargo run --release -- --grid, or using an installed version (see screenshot below).

This is a fairly severe regression as the the default expected behavior of exa/zetta is to run --grid if nothing else is specified.

ogham/exa#1165 (comment)

syphar/zetta#4

[cafkafk]

This existed before any of the merges thou, as discussed in zetta, but tracking and bisecting this issue is important, and I'll get on it after I'm done with the PRs

[cafkafk]

After a bisect, I've arrive here:

af208285e8a0fb383f59372c966bdb77f94006e9 is the first bad commit
commit af208285e8a0fb383f59372c966bdb77f94006e9
Author: Bastien Orivel <eijebong@bananium.fr>
Date:   Fri Dec 10 13:21:13 2021 +0100

    Update term_grid to 0.2

 Cargo.lock                 | 4 ++--
 Cargo.toml                 | 2 +-
 src/output/grid.rs         | 1 +
 src/output/grid_details.rs | 2 ++
 4 files changed, 6 insertions(+), 3 deletions(-)

af20828

Gonna see if I can solve it.

[cafkafk]

The plot thickens ogham/rust-term-grid#11

[cafkafk]

I'm pretty sure we should move to https://github.com/uutils/uutils-term-grid (see ogham/rust-term-grid#15), but for now I'll try to go back to rust-term-grid 0.1.

[sbatial]

I'm pretty sure we should move to https://github.com/uutils/uutils-term-grid (see ogham/rust-term-grid#15)

Agreed

[ariasuni]

Regarding uutils/uutils-term-grid#6, do you think the behavior should change in uutils-term-grid? I don’t really care myself but I figured it could matter to some people here.

[cafkafk]

Regarding uutils/uutils-term-grid#6, do you think the behavior should change in uutils-term-grid? I don’t really care myself but I figured it could matter to some people here.

I'm don't really care that much, at least when just looking at it initially. Of course if it's not that big of an issue, having it configurable would perhaps be preferred, but personally, I don't see it being an issue for my use.

I'd be interested in how other people feel about it however.

[Vistaus]

It's still broken for me, even in eza.

Eza version: 0.11
OS: openSUSE Tumbleweed
Terminal emulator: Yakuake

[ariasuni]

Do you think you could post a screenshot of the output of eza vs ls?

[LeoniePhiline]

eza --grid works for me on OpenSUSE Tumbleweed.
Terminal emulator: Konsole
Maybe Yakuake is the problem?

[Vistaus]

I figured it out: it had to do with the width. For some reason, if I set Yakuake to 60%, which I prefer, eza does not do grid. However, if I set it to 80%, it does work. Why it does not work with 60% is beyond me, as my screen is 2560x1440, so I have plenty of space to show a proper grid with 60%, but oh well. Thanks for all of your input!