Fix fit to grid failing in a common case #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariasuni
force-pushed
the
fix-fit-to-grid-failing
branch
from
64b8b5d
to
19f094b
Compare
ariasuni
force-pushed
the
fix-fit-to-grid-failing
branch
from
19f094b
to
d993878
Compare
|
@ogham any chance this can get merged? Or is this project abandoned/unmaintained?. I tested this and it fixes ogham/exa#990 |
|
Hi @ariasuni, I work on uutils and we decided to fork this repository over the inactivity: https://github.com/uutils/uutils-term-grid. I've started with fixing #11 and have made some performance improvements. We'd love to work with you and the other I've already made an issue for the test case you added in this PR, so we can discuss how to support the behaviour you describe: uutils/uutils-term-grid#6. If you're interested, please leave your thoughts there! Btw, I love |
This was referenced Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An off-by-one error. Fixing it broke some other tests, so I made a few other changes.
Fix #11
See: ogham/exa#990