Quote file names containing spaces and/or single quotes #1165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file name contains spaces, it will be wrapped in single quotes ('). If a file name contains literal single quotes, it will instead be wrapped in double quotes ("). This somewhat mimicks the default behaviour of modern-day GNU
ls
.This resolves #216 and contributes to #211. It also cleans up the code in the non-printable characters loop a bit.
I personally believe quotes should be the default, but a command-line switch (
--no-quotes
) exists for those who prefer not having them. This also provides a framework for supporting different quoting styles in the future.