Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote file names containing spaces and/or single quotes #1165

Closed
wants to merge 6 commits into from

Conversation

DenebTM
Copy link

@DenebTM DenebTM commented Feb 24, 2023

If a file name contains spaces, it will be wrapped in single quotes ('). If a file name contains literal single quotes, it will instead be wrapped in double quotes ("). This somewhat mimicks the default behaviour of modern-day GNU ls.

This resolves #216 and contributes to #211. It also cleans up the code in the non-printable characters loop a bit.

I personally believe quotes should be the default, but a command-line switch (--no-quotes) exists for those who prefer not having them. This also provides a framework for supporting different quoting styles in the future.

@DenebTM DenebTM marked this pull request as draft June 15, 2023 08:55
@DenebTM
Copy link
Author

DenebTM commented Jun 15, 2023

Changed to draft because I've realised that this messes with multi-column display in its current state.

@DenebTM
Copy link
Author

DenebTM commented Jul 25, 2023

After some more testing, I've realised that the grid view is currently broken on main.

Reopening as the problem lies somewhere else, not with this PR.

See recent comments on issues #885, as well as #990 and #1198.

@DenebTM
Copy link
Author

DenebTM commented Dec 7, 2023

closing this as the changes have been merged into the maintained fork, eza with #318

@DenebTM DenebTM closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support --quoting-style like ls (and quote filenames with spaces by default)
1 participant