Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(exa PR) 1165: Quote file names containing spaces and/or single quotes #20

Closed
wants to merge 10 commits into from

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Jul 29, 2023

@cafkafk
Copy link
Member Author

cafkafk commented Jul 29, 2023

I personally believe quotes should be the default, but a command-line switch (--no-quotes) exists for those who prefer not having them. This also provides a framework for supporting different quoting styles in the future.

This is opinionated and should be discussed. @sbatial how do you feel about the PR?

@cafkafk cafkafk added not ready for PRs that aren't finished needs feedback labels Jul 29, 2023
@sbatial sbatial mentioned this pull request Jul 30, 2023
63 tasks
@sbatial
Copy link
Collaborator

sbatial commented Jul 30, 2023

I tried it and it looks good on my end.

Reading ogham/exa#216 seems to indicate to me that using it as a default would make sense though.
I'm personally not sure. I don't think I've had any issues with that so far really so 🤷

Just to get a third opinion about someone for sure using the tool: Do you have any opinion on this @syphar?

@sbatial sbatial changed the title (exa PR) 1165 (exa PR) 1165: Quote file names containing spaces and/or single quotes Jul 30, 2023
@syphar
Copy link

syphar commented Jul 31, 2023

Just to get a third opinion about someone for sure using the tool: Do you have any opinion on this @syphar?

I can check this the next days (a screenshot would help with quicker judgement).

Purely from the PR description:

  • I can imagine quotes being added being useful
  • but only if it doesn't break the alignment of the filenames between quoted and unquoted.

there is also a (IMO lower prio) factor of scripts using the output for further tasks, though I'm not sure if this tool is used like this.

@cafkafk cafkafk added this to the exa pulls done milestone Jul 31, 2023
@sbatial
Copy link
Collaborator

sbatial commented Jul 31, 2023

image
Here's a screenshot.

The alignment is actually a good point/idea imo

@github-actions
Copy link

This pull request is stale because it has been open for 30 days with no activity.

@PThorpe92
Copy link
Member

PThorpe92 commented Sep 14, 2023

image

seems to be working now. Need some feedback here.

@PThorpe92 PThorpe92 marked this pull request as draft September 14, 2023 12:35
@PThorpe92 PThorpe92 removed not ready for PRs that aren't finished stale › pr labels Sep 14, 2023
@PThorpe92
Copy link
Member

Closed - redone in #318 due to messy af commit history and laziness in not wanting to rebase and squash them

@PThorpe92 PThorpe92 closed this Sep 14, 2023
@cafkafk cafkafk deleted the pr-1165 branch September 14, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants