-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(time_display): time should use /etc/timezone #721
base: main
Are you sure you want to change the base?
Conversation
I wasn't able to fix the commit message when it was pushed to github, so created a new PR. Sorry about that. |
fee4e88
to
fd3b877
Compare
When a file timestamp is displayed, it should use the timezone info from the time of the timestamp, not from when it is displayed. This occurs when a file timestamp is updated under daylight saving time, and displayed at a time when not under daylight saving time.
fd3b877
to
a170f97
Compare
Signed-off-by: Erwin <235739+erwinvaneijk@users.noreply.github.com>
Does this mean this PR should be closed? |
No, I already closed the broken branch . |
Signed-off-by: Erwin <235739+erwinvaneijk@users.noreply.github.com>
Nix doesn't seem to have /etc/localtime (or equivalent), which iana-time-zone doesn't like, as it depends on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to test this with libfaketime
and it didn't seem to actually change the dates to DST, how did you test this?
I've used the following sequence to create a testcase:
When using ls (from GNU coreutils):
When using eza from main branch:
with the updated eza from PR:
And, without the updated code the test in |
When a file timestamp is displayed, it should use the timezone info from the time of the timestamp, not from when it is displayed. This occurs when a file timestamp is updated under daylight saving time, and displayed at a time when not under daylight saving time.