Replace a couple of private_attr uses and remove the gem dependency #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only use this gem in 2 places, the warning the gem aims to address
("private attribute?") was removed in Ruby 2.3.0, and removing the
dependency seems worth it.
|
Code Climate has analyzed commit b146e22 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
zoso10
approved these changes
Dec 18, 2019
tjwp
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did we change?
Two instances of
private_attr_readerare replaced, and the top-levelprivate_attrgem dependency is removed.Why are we doing this?
We only use this gem in 2 places, the warning the gem aims to address ("private attribute?") was removed in Ruby 2.3.0, and removing the dependency seems worth it.
How was it tested?