Add support for redis 5.0.0 by replacing pipelined commands. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecation warnings for pipelined commandswas introduced in redis 4.6.0:
https://github.com/redis/redis-rb/blob/master/CHANGELOG.md#460
tristandunn
approved these changes
May 19, 2022
agrobbin
approved these changes
May 19, 2022
rusterholz
approved these changes
May 19, 2022
|
@rusterholz that would be great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did we change?
This change alters the
bulk_pushimplementation so that it no longer uses pipelined commands, which are now deprecated.Why are we doing this?
Resolves #54
Deprecation warnings for pipelined commands were introduced in redis 4.6.0
These warnings contribute to a large increase in log volume with newer versions of the redis gem.
How was it tested?