fix unmodifiable Map #130
Merged
fix unmodifiable Map #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezet
approved these changes
Mar 25, 2021
ezet
reviewed
Mar 25, 2021
| @@ -91,7 +91,8 @@ class StripeApi { | |||
|
|
|||
| /// Confirm a PaymentIntent | |||
| /// https://stripe.com/docs/api/payment_intents/confirm | |||
| Future<Map<String, dynamic>> confirmPaymentIntent(String clientSecret, {Map<String, dynamic> data = const {}}) async { | |||
There was a problem hiding this comment.
Would it be enough to just remove the const modifier?
There was a problem hiding this comment.
That was what I originally wanted to write, but was not possible.
error: The default value of an optional parameter must be constant. (non_constant_default_value at [stripe_sdk] lib\src\stripe_api.dart:113)
|
I tried the fix editing the stripe_sdk in pub-cache and it works for the method confirmSetupIntent! 👍🏻 |
|
@francislions I won't release another version to pub yet, so I suggest you pull the library from git for now. |
This was referenced May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129