Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMQ 2.1.1 #26

Closed
wants to merge 4 commits into from
Closed

RabbitMQ 2.1.1 #26

wants to merge 4 commits into from

Conversation

leemhenson
Copy link

Hi,

As requested, I've rebased the commits from my previous merge request onto ezmobius/master.

Cheers
Lee

Akeem Adeniji and others added 4 commits October 25, 2010 10:25
….8.0. With new version of RabbitMQ

, Durable and AutoDelete flags are checked for equivalence across seperate queuu.declare calls for
a given queue name.
…l use options to propagate secure setting ...
@roidrage
Copy link
Collaborator

Is there a reason you've removed :exclusive => true from the mapper? Was support for that removed in a newer version of RabbitMQ? I'd love to merge these patches, but they seem to fix some problems not necessarily all of them, as declaration of :durable => true doesn't seem to be fully consistent yet. I want to understand the changes before I merge them.

@leemhenson
Copy link
Author

Ok, so it breaks down like this:

  1. Never used RabbitMQ before
  2. Never used Nanite before

So I'm like someone stumbling around in the dark control room of a power station throwing switches left, right and centre in the hope that one of them turns on the lights. I appear to have turned the lights on, but I might have accidentally stuck a plutonium rod in a reactor somewhere at the same time. In other words, I've been trying combinations of settings and found some that work and as far as I can see, that's an improvement on "not working at all" which is the situation for 2.1.1 on ezmobius/master as it stands at the moment. If I've mucked something else up along the way, I apologise!

@roidrage
Copy link
Collaborator

I didn't say you've mucked up, just wanted to know the whole setting, that's cool. I'll look through them, and test the things for a little bit before I merge them.

@leemhenson
Copy link
Author

Groovy. Btw is the mapper_rework branch in a usable, stable-ish state? I'd rather be learning on the code that is most current, rather than the branch that is going to be made obsolete in the near future.

@roidrage
Copy link
Collaborator

I'm currently testing it. Things are looking good so far. It's not production ready, and will be subject for removal of features. Follow the mailing list, I'll give heads up over there on the status.

@roidrage
Copy link
Collaborator

These changes were already included with an earlier pull request, see #22, just merged them into master, thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants