Preserve passed options hash on Redis.connect.

ezmobius · Jul 30, 2010 · ec78af5 · ec78af5
1 parent 9daedf4
commit ec78af5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/redis.rb b/lib/redis.rb
@@ -16,6 +16,8 @@ def self.deprecate(message, trace = caller[0])
   attr :client
 
   def self.connect(options = {})
+    options = options.dup
+
     require "uri"
 
     url = URI(options.delete(:url) || ENV["REDIS_URL"] || "redis://127.0.0.1:6379/0")

diff --git a/test/redis_test.rb b/test/redis_test.rb
@@ -33,6 +33,14 @@ class RedisTest < Test::Unit::TestCase
       assert_equal "secr3t", redis.client.password
     end
 
+    test "doesn not modify the passed options" do
+      options = { :url => "redis://:secr3t@foo.com:999/2" }
+
+      redis = Redis.connect(options)
+
+      assert_equal({ :url => "redis://:secr3t@foo.com:999/2" }, options)
+    end
+
     test "uses REDIS_URL over default if available" do
       ENV["REDIS_URL"] = "redis://:secr3t@foo.com:999/2"