Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter "missed" declarations as well #347

Merged
merged 1 commit into from
Jun 7, 2022

Commits on Jun 5, 2022

  1. fix: filter "missed" declarations as well

    - these should run through the same `filter` as runs in `transform` etc
      - prior to this, the plugin `exclude` would filter files in
        `transform`, meaning no JS would be output for them, but would still
        output declarations for these very same files that no JS was
        produced for
        - (this would only happen if one were using an `include` glob or
          something that made the file appear twice, i.e. once by Rollup
          in `transform` and once in `parsedConfig.fileNames`)
      - this change makes it so the plugin `exclude` affects both JS
        and DTS output equivalently
        - it was very confusing when it didn't, and users relied on setting
          different `tsconfig` `exclude`s to workaround this (as a
          `tsconfig` `exclude` would make the file not appear in
          `parsedConfig.fileNames`)
    agilgur5 committed Jun 5, 2022
    Configuration menu
    Copy the full SHA
    b0fd71c View commit details
    Browse the repository at this point in the history