refactor: combine two context files into one #396
Merged
+119
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- they're virtually identical, so combine them instead of keeping them separate - changes to one should probably be made to both - still a < 100 LoC file - refactor out `_.isFunction` with a simple `getText` function instead - checks the opposite - one more lodash removal! - add docstrings about when to use the two contexts
agilgur5
added
the
kind: internal
|
Very likely that |
This was referenced Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merge the two context files into a single file as they're intended to be as similar as possible. They're also not meant to be more extensible to create other contexts (unlike say, the cache interfaces etc), these are the only two contexts intended.
IMO, the slight, small distinction between them would've been easier to understand/catch on to if I saw them together like this than in separate files.
Details
they're virtually identical, so combine them instead of keeping them separate
refactor out
_.isFunctionwith a simplegetTextfunction insteadlodashremoval! (follow-up to refactor: prefer native methods to lodash where possible #328)add docstrings about when to use the two contexts
Future Work
diagnosticsfiles and thetsconfigfiles, as they're also only used in the same context and not in other contexts. Planning to add more unit tests first though