Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: combine two context files into one #396

Merged
merged 2 commits into from Aug 19, 2022
Merged

refactor: combine two context files into one #396

merged 2 commits into from Aug 19, 2022

Commits on Jul 22, 2022

  1. refactor: combine two context files into one 

    - they're virtually identical, so combine them instead of keeping them separate
  - changes to one should probably be made to both
  - still a < 100 LoC file

- refactor out `_.isFunction` with a simple `getText` function instead
  - checks the opposite
  - one more lodash removal!

- add docstrings about when to use the two contexts
    @agilgur5
    agilgur5 committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    b9f1fd6 View commit details
    Browse the repository at this point in the history

  2. disable tslint rule for this file

    @agilgur5
    agilgur5 committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    2f7988e View commit details
    Browse the repository at this point in the history